Thread (4 messages) 4 messages, 2 authors, 2007-02-28

Re: [PATCH] display class

From: James Simmons <hidden>
Date: 2007-02-27 21:46:55
Also in: lkml

this stuff looks el-crappo in an 80-col display.
Cleaning up....
This guy can have static scope.

It's a bit awkward having a fixed size.  I think lib/idr.c would suit for
this.

Also, we do set_bit() and clear_bit() on this, which are needlessly atomic. 
If we hold a suitable lock then we can use __set_bit() and __clear_bit().

And we do need a suitable lock.
Fixing... Never knew about idr. Hum nice :-) I will have a new patch your 
way. I just need to do some teste first.
Why all the ifdeffery?  I think plain old


static void __exit display_class_exit(void)
{
	class_destroy(display_class);
}
module_exit(display_class_exit);
module_init(display_class_init);
That is from the hunting of the bug with the broken symlinks in /sys. Will 
go back to sanity.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help