On Thu, Feb 22, 2007 at 12:59:06AM +0000, Richard Purdie wrote:

Reading through the patch its:

1) Not against any mainline kernel
2) Not against a recent kernel

I'm sorry, but the patch applay against the latest kernel. Please, try
it.

There were a number of backlight class changes just merged into mainline
and you need to sync up any patch against them.

My patch uses current backlight class support in the kernel.

As mentioned by others, there is no need to tie the backlight driver
into the framebuffer any more. Have a look at
drivers/video/backlight/corgi_bl.c for an example (its used by PXA
devices).

That driver uses the backlight class support as my patch does into
pxafb.

I have said elsewhere I will take patches to make corgi_bl a more
generic driver (or maybe create a simple generic backlight driver) along
the lines of what Paul mentioned.

I see.

I suppose you are the backlight support mantainer, so what do you
suggest to do to "make corgi_bl a more generic driver"?

I have to rename and modify it? Or just copy it to have backward
compatibility and the modify the new file?

I should mv backlight directory from the video one?

Thanks for your suggestions,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@gnudd.com
Embedded Systems                     		giometti@linux.it
UNIX programming                     phone:     +39 349 2432127