Re: [Linux-fbdev-devel] [PATCH] fb: SM501 framebuffer driver (#5)
flat view
From: Ben Dooks <hidden>
Date: 2007-02-16 10:12:52
Also in:
lkml
On Fri, Feb 16, 2007 at 09:50:45AM +0000, Ben Dooks wrote:
Driver for the Silicon Motion SM501 multifunction device framebuffer subsystem. This driver supports both the CRT and LCD panel heads, with some simple acceleration for the cursor plotting and support for screen panning. There is no current support for bitblt/drawing engines, which should be added at a later date. This has been tested on a number of configurations, including PCI and generic-bus, on PPC, ARM and SH4
The difference between this and the previous version is
that the checks in pan display have been removed, as per
James' suggestion:
diff -urpN -X ../dontdiff linux-2.6.20-sm501-2/drivers/video/sm501fb.c linux-2.6.20-sm501-3/drivers/video/sm501fb.c--- linux-2.6.20-sm501-2/drivers/video/sm501fb.c 2007-02-13 19:14:47.000000000 +0000
+++ linux-2.6.20-sm501-3/drivers/video/sm501fb.c 2007-02-16 09:33:07.000000000 +0000@@ -496,23 +496,6 @@ static void sm501fb_set_par_geometry(str writel(reg, base + SM501_OFF_DC_V_SYNC); } -/* sm501fb_validate_pan - * - * check panning on a var -*/ - -static inline int sm501fb_validate_pan(struct fb_var_screeninfo *var) -{ - if (var->xoffset < 0 || var->yoffset < 0) - return 0; - - if (var->xoffset > (var->xres_virtual - var->xres) || - var->yoffset > (var->yres_virtual - var->yres)) - return 0; - - return 1; -} - /* sm501fb_pan_crt * * pan the CRT display output within an virtual framebuffer
@@ -527,9 +510,6 @@ static int sm501fb_pan_crt(struct fb_var unsigned long reg; unsigned long xoffs; - if (!sm501fb_validate_pan(var)) - return -EINVAL; - xoffs = var->xoffset * bytes_pixel; reg = readl(fbi->regs + SM501_DC_CRT_CONTROL);
@@ -558,9 +538,6 @@ static int sm501fb_pan_pnl(struct fb_var struct sm501fb_info *fbi = par->info; unsigned long reg; - if (!sm501fb_validate_pan(var)) - return -EINVAL; - reg = var->xoffset | (var->xres_virtual << 16); writel(reg, fbi->regs + SM501_DC_PANEL_FB_WIDTH);
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'