Re: [PATCH 8/9] ps3: cleanup ps3fb before clearing HPTE
flat view
From: Christoph Hellwig <hch@lst.de>
Date: 2007-01-26 03:14:48
Also in:
linuxppc-dev
On Thu, Jan 25, 2007 at 06:51:50PM +0100, Geert Uytterhoeven wrote:
quoted hunk ↗ jump to hunk
PS3: Cleanup the frame buffer device before clearing the HPTE mapping Signed-off-by: Geert Uytterhoeven <redacted> --- arch/powerpc/platforms/ps3/htab.c | 5 +++++ 1 files changed, 5 insertions(+)--- ps3-linux.orig/arch/powerpc/platforms/ps3/htab.c +++ ps3-linux/arch/powerpc/platforms/ps3/htab.c@@ -234,6 +234,11 @@ static void ps3_hpte_invalidate(unsigned static void ps3_hpte_clear(void) { + extern void ps3fb_cleanup(void);
Externs belong into headers.
quoted hunk ↗ jump to hunk
+ +#ifdef CONFIG_FB_PS3 + ps3fb_cleanup(); +#endif
And well, adding framebuffer calls into the mmu code is rather fucked. This at least needs a big comment explaning the hypervisor braindamage that is responsible for this in colourfull language.