Hi,

On Tuesday 05 December 2006 13:03, James Simmons wrote:

+int probe_edid(struct display_device *dev, void *data)
+{
+       struct fb_monspecs spec;
+       ssize_t size = 45;

const ssize_t size = 45? 

+
+       dev->name = kzalloc(size, GFP_KERNEL);

Why do you need kzalloc here?

+       fb_edid_to_monspecs((unsigned char *) data, &spec);
+       strcpy(dev->name, spec.manufacturer);

You seem to be overwriting dev->name in the very next line?

+       return snprintf(dev->name, size, "%s %s %s\n", spec.manufacturer, spec.monitor, spec.ascii);

Is result of snprintf interesting to the callers?

-- 
Dmitry