Hi Paul,

Paul Mackerras wrote:

This is an fbdev driver for the IBM GXT4500P display card found in
some IBM System P (pSeries) machines.  These cards have hardware 2D
and 3D capabilities, but the driver does not use them; it just exports
a dumb framebuffer.

You might try to "const"-ify a few static structs and arrays...

Helge

+/* Indexed by DFA_PIX_* values */
+static unsigned char watfmt[] = {
+     WAT_FMT_8BIT, WAT_FMT_16BIT_565, WAT_FMT_16BIT_1555, 0,

+static unsigned char mdivtab[] = {
+/* 1 */                    0x3f, 0x00, 0x20, 0x10, 0x28, 0x14, 0x2a, 0x15, 0x0a,

+static unsigned char ndivtab[] = {
+/* 2 */                          0x00, 0x80, 0xc0, 0xe0, 0xf0, 0x78, 0xbc, 0x5e,

not sure about those:

+static struct fb_bitfield eightbits = {0, 8};
+static struct fb_bitfield nobits = {0, 0};

+static struct fb_ops gxt4500_ops = {
+     .owner = THIS_MODULE,

+static struct pci_device_id gxt4500_pci_tbl[] = {
+     { PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_GXT4500P,
+       PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },

maybe this one:

+static struct pci_driver gxt4500_driver = {
+     .name = "gxt4500",

and maybe more ?



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV