Re: [Linux-fbdev-devel] fb: modedb uses wrong default_mode
flat view
From: Tero Roponen <hidden>
Date: 2006-11-18 10:39:46
Also in:
lkml
On Fri, 17 Nov 2006, Andrew Morton wrote:
quoted hunk ↗ jump to hunk
Here's the current version of this monster patch: From: Jordan Crouse <redacted> If no default mode is specified, it should be grabbed from the supplied database, not the default one. [teanropo@jyu.fi: fix it] [akpm@osdl.org: simplify it] [akpm@osdl.org: remove pointless DEFAULT_MODEDB_INDEX] Signed-off-by: Jordan Crouse <redacted> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "Antonino A. Daplas" <redacted> Signed-off-by: Tero Roponen <redacted> Cc: James Simmons <redacted> Signed-off-by: Andrew Morton <redacted> --- drivers/video/modedb.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN drivers/video/modedb.c~video-get-the-default-mode-from-the-right-database drivers/video/modedb.c--- a/drivers/video/modedb.c~video-get-the-default-mode-from-the-right-database +++ a/drivers/video/modedb.c@@ -34,8 +34,6 @@ const char *global_mode_option; * Standard video mode definitions (taken from XFree86) */ -#define DEFAULT_MODEDB_INDEX 0 - static const struct fb_videomode modedb[] = { { /* 640x400 @ 70 Hz, 31.5 kHz hsync */@@ -505,8 +503,10 @@ int fb_find_mode(struct fb_var_screeninf db = modedb; dbsize = ARRAY_SIZE(modedb); } + if (!default_mode) - default_mode = &modedb[DEFAULT_MODEDB_INDEX]; + default_mode = &db[0]; + if (!default_bpp) default_bpp = 8;_
I'm using neofb and this Works For Me (TM). Thanks, Tero Roponen