Re: [PATCH] nvidiafb: fix unreachable code in nv10GetConfig
From: Andrew Morton <hidden>
Date: 2006-11-08 20:14:14
Also in:
lkml
On Wed, 8 Nov 2006 13:55:11 -0600 Nathan Lynch [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fix binary/logical operator typo which leads to unreachable code. Noticed while looking at other issues; I don't have the relevant hardware to test this. Signed-off-by: Nathan Lynch <redacted>--- linux-2.6-powerpc.git.orig/drivers/video/nvidia/nv_setup.c +++ linux-2.6-powerpc.git/drivers/video/nvidia/nv_setup.c@@ -262,7 +262,7 @@ static void nv10GetConfig(struct nvidia_ #endif dev = pci_find_slot(0, 1); - if ((par->Chipset && 0xffff) == 0x01a0) { + if ((par->Chipset & 0xffff) == 0x01a0) { int amt = 0; pci_read_config_dword(dev, 0x7c, &amt);
That looks like a pretty significant bug. It'll cause the kernel to potentially map the wrong amount of memory for all cards except the NV_ARCH_04 type. Has been there for over a year though. hmm.. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642