patch review

Started by James Simmons on Nov 17, 2006

open the first message on its own page

Message details and related content
I have been reviewing and testing your patches. I haven't tested them all 
tho. I have tested:

annotate-some-variables-in-vesafb.patch
fbcmapc-mark-structs-const-or.patch
gregkh-driver-fb-device.patch
ioremap-balanced-with-iounmap-for-drivers-video-vesafb.patch
various-fbdev-files-mark-structs-fix.patch
various-fbdev-files-mark-structs.patch

I had no problem with them. I will test the atyfb patches tomorrow.
Please drop the 

fbmem-is-bootup-logo-broken-for-monochrome-lcd.patch

It does address several problems but there are more problmes then that. I 
like to send out another patch to would address all those issues.
Thanks.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help