Re: [PATCH 1/3] fbdev: Add framebuffer and display update module support for pnx4008
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2006-07-01 05:03:59
Andrew Morton wrote:
On Fri, 30 Jun 2006 20:00:23 +0800 "Antonino A. Daplas" [off-list ref] wrote:quoted
+ if ((ret = put_cmd_string(cmds_c)) != 0) { + return ret; + }Guys, please avoid the assign-then-test trick. Kernel style is super-simple style. The above should be coded as:
I'm kinda lax when it comes to this style, but if you insist :-)
ret = put_cmd_string(cmds_c); if (ret != 0) return ret; Nice and easy.
Tony Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642