Re: [PATCH 0/7] Detaching fbcon
From: Jon Smirl <hidden>
Date: 2006-06-06 21:00:38
Also in:
lkml
On 6/6/06, Antonino A. Daplas [off-list ref] wrote:
Jon Smirl wrote:quoted
On 6/6/06, Jon Smirl [off-list ref] wrote:quoted
On 6/6/06, Antonino A. Daplas [off-list ref] wrote:quoted
Overall, this feature is a great help for developers working in the framebuffer or console layer. There is not need to continuallyreboot thequoted
kernel for every small change. It is also useful for regular userswho wantsquoted
to choose between a graphical console or a text console withouthaving toquoted
reboot.Instead of the sysfs attribute, what about creating a new escape sequence that you send to the console system to detach? Doing it that way would make more sense from a stacking order. It just seems backwards to me that you ask a lower layer to detach from the layer above it. The escape sequence would also work for any console implementation, not just fbcon. If console detached this way and there was nothing to fallback to (systems without VGAcon), it would know not to try and print anything until something reattaches to it.Another thought, controlling whether console is attached or not is an attribute of console, not of fbcon.If the console attached fbcon, then I agree that console should decide when to detach fbcon. But that's not what happens, it's fbcon that attaches itself. It's not that you're wrong, it's just how the current vt/console layer works. If someone do decide to add this feature to the vt/console layer, then I'm more than willing to have fbcon support that as well.
This is just kind of twisted since console increments the fbcon ref count. Is /dev/console a real device, it that where the sysfs attribute should go? How is the stack maintained of what was previously bound to console? What if I unbind fbcon on a system that doesn't have VGAcon for a backup? -- Jon Smirl jonsmirl@gmail.com