Thread (4 messages) 4 messages, 4 authors, 2006-05-27

[PATCH 2.6.17-rc4-mm3] intelfb 945G/GM video fix

flat view
STALE7442d

From: Dennis Munsie <hidden>
Date: 2006-05-25 20:38:34

Hi all,

This is a small patch that I would like others to take a look at.  We ran into an issue where on the motherboard we are using, Intel D945GTP, the video wouldn't come up in the proper state even with Dave Airlie's patches for 945.  I had created a 945 patch that I hadn't released, and that one did work.  The only difference between the two was that I had a one line hack to write to the DPLL register twice.  Now, this should be harmless on other chipsets, but I can't be sure without testing.  I've tried asking Intel about this, but I haven't gotten any information on it from them.

any feedback would be appreciated.

dennis

---

From: Dennis Munsie <redacted>

Writes to the DPLL register twice which fixes a problem on my machine where the
video doesn't come up at all.  This has been tested on a Intel D945GTP board
and also on a Intel D915GUXL board.

Signed-off-by: Dennis Munsie <redacted>

---

drivers/video/intelfb/intelfbhw.c |    1 +
1 file changed, 1 insertion(+)

diff -Naurp -X linux-2.6.17-rc4-intelfb-mm/Documentation/dontdiff linux-2.6.17-rc4-intelfb-mm/drivers/video/intelfb/intelfbhw.c linux-2.6.17-rc4-945_fix/drivers/video/intelfb/intelfbhw.c
--- linux-2.6.17-rc4-intelfb-mm/drivers/video/intelfb/intelfbhw.c	2006-05-25 15:16:44.000000000 -0500
+++ linux-2.6.17-rc4-945_fix/drivers/video/intelfb/intelfbhw.c	2006-05-25 15:31:45.000000000 -0500
@@ -1384,6 +1384,7 @@ intelfbhw_program_mode(struct intelfb_in
	tmp = INREG(dpll_reg);
	tmp |= DPLL_VCO_ENABLE;
	OUTREG(dpll_reg, tmp);
+	OUTREG(dpll_reg, tmp); /* twice for the 945G/GM chipsets -- others should ignore it */
	/* Set DVOs B/C */
	OUTREG(DVOB, hw->dvob);



-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help