On Fri, Feb 24, 2006 at 10:15:21AM +1100, Benjamin Herrenschmidt wrote:

quoted

I'm unsure how to best to proceed from here, so this patch is it until 
I get some more directed feedback.  

I'll review properly next week.

I've since completely gutted the radeon_probe_screens code, and now it 
takes advantage of (and relies heavily on) the connector table stuffs.  
It's far, far cleaner now, yay!   

I basically have two chunks of remaining code to write:

1) The OpenFirmware stuff, which basically requires some re-jiggering of 
   arguments passed in and return codes.  
2) User-specified layout code isn't smart enough to try the secondary 
   connectors if the primary connectors don't have anything connected.
   (This could be lessened by extending the syntax to explicitly state 
    CRT,CRT2,DFP,DFP2,etc..)

Then there's the big open question of how we should allow the user
to override the connector table, in case we mis-detect or don't have a
table to begin with.  If we have DDC enabled we can build a 
connector table by probing all DDC ports, using the existing logic. 

Thoughts?

(This work builds on the radeon-atom-4 patch, and is definately in the 
 "heavily experimental" stage.  I'll post a patch once I have time to 
 clean it up and fix the first two points)

 - Solomon
-- 
Solomon Peachy        				 ICQ: 1318344
Melbourne, FL
Quidquid latine dictum sit, altum viditur.