Cyblafb: Remove unneeded code

Started by Knut Petersen on Dec 21, 2005

Subsystems (1)

Maintainers (1)

DORMANTno replies

open the first message on its own page

Message details and related content
Initialization of GEB8 ... GED4 is removed in the graphics engine
setup function. GEB8 and GEC8 are set in the drawing functions now,
and all other registers never were used.

Signed-off-by: Knut Petersen <redacted>

diff -uprN -X linux/Documentation/dontdiff -x '*.bak' -x '*.ctx' linuxorig/drivers/video/cyblafb.c linux/drivers/video/cyblafb.c
--- linuxorig/drivers/video/cyblafb.c	2005-12-21 10:49:51.000000000 +0100
+++ linux/drivers/video/cyblafb.c	2005-12-21 10:11:34.000000000 +0100
@@ -220,21 +220,10 @@ static void cyblafb_setup_GE(int pitch,i

 	write3X4(CR36,0x90);	// reset GE
 	write3X4(CR36,0x80);	// enable GE
-
-	out32(GE24,1<<7);	// reset all GE pointers
-	out32(GE24,0);
-
+	out32(GE24,1<<7);	// reset all GE pointers by toggling
+	out32(GE24,0);		//   d7 of GE24
 	write3X4(CR2D,0x00);	// GE Timinigs, no delays
-
-	out32(GEB8,base); // Destination Stride / Buffer Base 0, p 133
-	out32(GEBC,base); // Destination Stride / Buffer Base 1, p 133
-	out32(GEC0,base); // Destination Stride / Buffer Base 2, p 133
-	out32(GEC4,base); // Destination Stride / Buffer Base 3, p 133
-	out32(GEC8,base); // Source Stride / Buffer Base 0, p 133
-	out32(GECC,base); // Source Stride / Buffer Base 1, p 133
-	out32(GED0,base); // Source Stride / Buffer Base 2, p 133
-	out32(GED4,base); // Source Stride / Buffer Base 3, p 133
-	out32(GE6C,0);	  // Pattern and Style, p 129, ok
+	out32(GE6C,0);		// Pattern and Style, p 129, ok
 }

 //=====================================================================



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help