Re: [2.6 patch] drivers/video/: possible cleanups
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2005-11-06 05:56:15
Also in:
lkml
Adrian Bunk wrote:
quoted hunk ↗ jump to hunk
This patch contains the possible cleanups including the following: - every file should #include the headers containing the prototypes for it's global functions - make needlessly global functions static - kyro/STG4000Interface.h: #include video/kyro.h and linux/pci.h instead of a manual "struct pci_dev" - i810_main.{c,h}: prototypes for static functions belong to the C file Signed-off-by: Adrian Bunk <redacted> --- drivers/video/arcfb.c | 8 +-- drivers/video/console/softcursor.c | 2 drivers/video/i810/i810-i2c.c | 1 drivers/video/i810/i810_accel.c | 1 drivers/video/i810/i810_gtf.c | 1 drivers/video/i810/i810_main.c | 51 ++++++++++++++++++-- drivers/video/i810/i810_main.h | 56 +--------------------- drivers/video/kyro/STG4000InitDevice.c | 1 drivers/video/kyro/STG4000Interface.h | 3 - drivers/video/kyro/STG4000OverlayDevice.c | 1 drivers/video/matrox/matroxfb_g450.c | 2 drivers/video/nvidia/nv_hw.c | 1 drivers/video/tdfxfb.c | 2 13 files changed, 68 insertions(+), 62 deletions(-)--- linux-2.6.14-rc5-mm1-full/drivers/video/console/softcursor.c.old 2005-11-06 00:31:15.000000000 +0100 +++ linux-2.6.14-rc5-mm1-full/drivers/video/console/softcursor.c 2005-11-06 00:31:30.000000000 +0100@@ -17,6 +17,8 @@ #include <asm/uaccess.h> #include <asm/io.h> +#include "fbcon.h"
I don't think softcursor needs anything in fbcon.h. The rest looks okay. Tony ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php