Re: mono, gray and index configs

On 8/22/05, Geert Uytterhoeven [off-list ref] wrote:

On Fri, 19 Aug 2005, Jon Smirl wrote:

quoted

The patch is just for testing, don't send it on. The radeonfb portion
is definitely not finished.

This adds an optional function to each driver that advertises what
configs it offers.

+char *radeonfb_getconfigs(struct fb_info *info)
+{
+     return "I4\nI8\nA1R5G5B5\nR5G6B5\nR8G8B8\nA8R8G8B8\nA4R4G4B4\nA8I8\nA2R10G10B10\n";
+}

  static struct fb_ops radeonfb_ops = {
      .owner                  = THIS_MODULE,

@@ -1873,6 +1909,7 @@ static struct fb_ops radeonfb_ops = {
      .fb_fillrect            = radeonfb_fillrect,
      .fb_copyarea            = radeonfb_copyarea,
      .fb_imageblit           = radeonfb_imageblit,
+     .fb_get_configs         = radeonfb_getconfigs,
 };

Do we really need this?

It is optional. It's used in sysfs, where you cat the config variable
to get a list of valid configs. Once in sysfs a program could then use
it to generate a list to pick from, etc...

It seems hard to use the search method if you are looking for a config
that is in the middle of the list.

-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf