Re: [PATCH] geode updates.
From: David Vrabel <hidden>
Date: 2005-08-17 12:10:17
Attachments
- geodefb-fixes [text/plain] 11747 bytes · preview
From: David Vrabel <hidden>
Date: 2005-08-17 12:10:17
James Simmons wrote:
Okay I see what you meant. So what I did was create two hardware devices. One a pci device for the Cyrix video so it will show up in the sysfs pci tree. A second platform device for the embedded geode GX processsor.
You'll hate me for this but I've changed my mind... I think making it a single PCI driver is best because: 1. PCI devices can be autodetected etc. but platform devices can't. 2. Having the platform and pci driver is extra complexity for no practical benefit. 3. The framebuffer memory is a pci resource in BAR0 of the cs5530 video device anyway. Attached is a tested patch that does this (based on one of your previous patches). David Vrabel -- David Vrabel, Design Engineer Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233 Cambridge CB1 7EA, UK Web: http://www.arcom.com/