Re: Optimizing bitblit.c / fb_pad_*
From: James Simmons <hidden>
Date: 2005-08-03 17:34:20
why not make it to something like this?
for (i = cellsize; i--;) {
*dstp = src[cellsize-1-i];
dstp += pitch;
}
This way, it will work with any fontsize, as long as the width
is a 8-bit size-aligned. You can do the same with
fb_pad_aligned_buffer(), so the rest can benefit too.
The above is probably a bit slower than your version, but it's a
good compromise -- bit_putcs is ugly enough, the price for
the optimization.
Tony
PS: Next time you submit a patch, add a Signed-off-line. See this
document by akpm:
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txtIf you embedded everything then there is no reason to do massivce copies. Right now this is not the highest priority. We have alot of other fixes that need to go in. ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click