Re: Move softcursor out of fbdev to fbcon
flat view
From: James Simmons <hidden>
Date: 2005-07-27 22:06:20
The changelog says it all. This is a modification of Jon's patch, but I have moved softcursor.c to the console directory. Also I removed the "select FB_SOFTCURSOR" from video/Kconfig and made the compilation of softcursor unconditional, if framebuffer console is enabled. I don't think the fb_cursor hook is usable by other programs, so we should just restrict this hook for fbcon use only. For userspace cursor support, we need a new one. But instead of one function, I believe it's better to provide several. Ie, something like below: fbcursor_show() fbcursor_move() fbcursor_loadimage() fbcursor_loadpalette() fbcursor_start() fbcursor_stop() No need to pass all variables to just, say, move the cursor to x,y. And the next step is to eliminate all fbcon-specific fields from fb_info to another structure, such as fb_imageblit, fb_fillrect, fb_cursor, fb_copyarea. We'll have a smaller kernel size for if fbcon is not enabled. Comments?
Its way to big and gross. Please keep it simple!!!!!! ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf