Re: [RFC/PATCH 2.6.12-rc5 1/1] Framebuffer driver for Arc LCD board

Hi Antonino, Andrew, FBdev folk,

I added akpm's fixes below, then further cleanup and irq support: 
- coding style fixes
- removing unneeded typecasts
- namespace fixes

I had used skeletonfb.c to start with and that had fb_get_options.
I've removed that and the redundant param retrieval from arcfb as 
per akpm's mention of the redundancy of fb_get_options/*_setup. 
I also cleaned up some other duplicate code. I've listed the 
driver as maintained and added myself. I did this diff against
rc5. Should I be doing it against -mm instead?

Please let me know if you have any feedback or suggestions.

It looks really good :-) Please apply.



-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.  
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20