Re: Re: 2.6.12-rc1-mm2 -- nvidiafb driver gives black screen
From: Jean Delvare <hidden>
Date: 2005-04-14 17:13:19
Hi Tony,
This patch will always limit the amount of video RAM to remap at 128 MiB.
I don't much get the idea. What are you trying to prevent? 128 MiB seems a rather low limit. Graphics adapters with 256 MiB, 512 MiB or even 640 MiB exist, and I see little reason why it would stop increasing.
quoted hunk ↗ jump to hunk
diff -Nru a/drivers/video/nvidia/nvidia.c b/drivers/video/nvidia/nvidia.c--- a/drivers/video/nvidia/nvidia.c 2005-04-14 13:33:38 +08:00 +++ b/drivers/video/nvidia/nvidia.c 2005-04-14 13:44:15 +08:00@@ -1510,7 +1510,11 @@ par->FbMapSize = par->RamAmountKBytes * 1024; if (vram && vram * 1024 * 1024 < par->FbMapSize) - par->FbMapSize = vram * 1024 * 1024; + par->FbMapSize = vram * 1024 * 1024;
You're fixing an indentation error you just introduced in the previous patch. Maybe you could fix the first patch instead? Thanks, -- Jean Delvare ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click