Re: [Linux-fbdev-devel] Re: [ACPI] inappropriate use of in_atomic()

From
Andrew Morton <hidden>
Date
2005-03-12 00:20:37
Also in
linux-acpi, lkml
Reply to
Benjamin Herrenschmidt, 2005-03-11
(where'd my cc go?)

Benjamin Herrenschmidt [off-list ref] wrote:
On Fri, 2005-03-11 at 01:46 -0800, Andrew Morton wrote:
quoted
Jan Kasprzak [off-list ref] wrote:
quoted
This may be the cause of 

 http://bugme.osdl.org/show_bug.cgi?id=4150
Looks that way, yes.
Note that it would be interesting to fix that (I mean the reliability of
is_atomic() or an alternative). I agree it's quite bad to rely on that
in practice, but there are a few corner cases where it's useful (like
oops handling in fbdev's etc...)
That would require that we increment current->something on every
spin/read/write_lock and decrement it in unlock, even with !CONFIG_PREEMPT.

iirc, Anton added an option to do that to the ppc64 build, decoupled from
CONFIG_PREEMPT (which ppc64 doesn't support).

But it's an appreciable amount of overhead.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
Thread (7 messages) 7 messages, 4 authors, last reply 2005-03-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help