On Fri, 18 Mar 2005, Sascha Hauer wrote:

+static struct imxfb_rgb def_rgb_16 = {
+	.red	= { offset: 8,  length: 4, },
+	.green	= { offset: 4,  length: 4, },
+	.blue	= { offset: 0,  length: 4, },
+	.transp = { offset: 0,  length: 0, },
+};
+
+static struct imxfb_rgb def_rgb_8 = {
+	.red	= { offset: 0,  length: 8, },
+	.green	= { offset: 0,  length: 8, },
+	.blue	= { offset: 0,  length: 8, },
+	.transp = { offset: 0,  length: 0, },
+};

Please use C99-style struct initializers for offset and length as well.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click