Re: [PATCH 8/10] fbdev: Allow core fb to be built as a module
From: Jon Smirl <hidden>
Date: 2005-03-08 04:50:14
On Mon, 7 Mar 2005 17:47:36 -0800, Andrew Morton [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Jon Smirl [off-list ref] wrote:quoted
Not sure if ppc will build since I don't have a machine to check it on.ppc seems OK. Now x86 `allmodconfig' is unhappy. *** Warning: "fb_find_logo" [drivers/video/fb.ko] undefined! diff -puN drivers/video/logo/logo.c~fbdev-allow-core-fb-to-be-built-as-a-module-fix-fix drivers/video/logo/logo.c--- 25/drivers/video/logo/logo.c~fbdev-allow-core-fb-to-be-built-as-a-module-fix-fix 2005-03-07 17:42:38.000000000 -0800 +++ 25-akpm/drivers/video/logo/logo.c 2005-03-07 17:42:38.000000000 -0800@@ -12,6 +12,7 @@ #include <linux/config.h> #include <linux/linux_logo.h> #include <linux/stddef.h> +#include <linux/module.h> #ifdef CONFIG_M68K #include <asm/setup.h>@@ -99,4 +100,4 @@ const struct linux_logo *fb_find_logo(in } return logo; } - +EXPORT_SYMBOL_GPL(fb_find_logo);_
Did you fix this or do I need to send another patch? I didn't know about allmodconfig so I'll be sure and run it. It's about time fb became a module, it's been built in for about ten years. -- Jon Smirl jonsmirl@gmail.com ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click