Re: Patch to add mode setting to sysfs

On Saturday 19 February 2005 05:59, Antonino A. Daplas wrote:

On Saturday 19 February 2005 00:46, Jon Smirl wrote:

quoted

On Fri, 18 Feb 2005 15:42:50 +0800, Antonino A. Daplas

[off-list ref] wrote:

quoted

On Friday 18 February 2005 15:27, Jon Smirl wrote:

quoted

Next version of sysfs patch. Fills out more attributes. Feel free to
add code for missing implementations. Modifies fbcon to copy mode
structure instead of taking a reference to it. Modular fbdev is
separate patch. Ultimately we should be able to eliminate the IOCTL
code from fb_core and move it to a compatibility module.

Okay, I think I can start coding starting from this patch.

Do you want to take over the sysfs support? If so, I will make some
changes to the radeonfb driver that I need. That will keep up from
conflicting.

Actually, I plan to do the fbcon part only, capturing the event. I'll use
yours as the test bed, but you and James will have to agree on the best way
to add sysfs support to the fb core.

Attached are 2 test patches.  The first (fbsysfs.diff) is Jon's practically
unmodified code, but with cosmetic changes and the mode copy reverted back
to mode pointer (I prefer the pointer since it will crash rather than
silently fail if there's a bug, besides consuming less memory).

The second patch (fbcon-new-modelist.diff) adds a new event,
FB_EVENT_NEW_MODELIST.  This is sent by store_modes() via fb_new_modelist().
The event is captured by fbcon and resizes all consoles based on the new
modelist.

Tony