[PATCH 2/7] fbdev: Make fb_find_mode() return failure if modular
STALE7898d
From: Antonino A. Daplas <hidden>
Date: 2005-02-17 12:49:34
A few drivers call fb_find_mode() even if compiled as a module. If the modedb parameter is NULL, the function will use default modedb array which is marked __init. This will cause a crash. To avoid this, check if the driver is compiled as a module, and if it is, fail. Signed-off-by: Antonino Daplas <redacted> --- modedb.c | 4 ++++ 1 files changed, 4 insertions(+) diff -Nru a/drivers/video/modedb.c b/drivers/video/modedb.c
--- a/drivers/video/modedb.c 2005-02-17 19:29:47 +08:00
+++ b/drivers/video/modedb.c 2005-02-15 22:54:57 +08:00@@ -474,11 +474,15 @@ { int i; + if (!db && (info->flags & FBINFO_MODULE)) + return 0; + /* Set up defaults */ if (!db) { db = modedb; dbsize = sizeof(modedb)/sizeof(*modedb); } + if (!default_mode) default_mode = &modedb[DEFAULT_MODEDB_INDEX]; if (!default_bpp) -------------------------------------------------------
SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click