Re: [patch] generic framebuffer support, cleanups and buglets with BPP < 32 (fwd)

Changes:
 * removed trailing whitespace
 * use helper function for common bitwise operations
 * fixed several cases where either the wrong mask was used for bitops
   or the mask was computed falsely, messing up <32 BPP support
 * added self-tests for bitcpy_rev() algorithm in module-init function
 * no need to use explicitly sized integers in some cases
 * added a few comments where things weren't obvious to me

Merged a few changes from me.

   * Replaced LONG_MASK, SHIFT_PER_LONG, BYTES_PER_LONG with dynamic
     variables. This will allow drivers in the future to control how much
     data to read/write from the framebuffer.

Give it a try. I did remove the DEBUG code. We need a cleaner way to test
those functions independent of the driver.

I tested these changes on an Au1100 based board, using the patches to its 
framebuffer code that were posted here by Christian Pellegrin[1]. I had this 
code working both on a 16BPP color LCD and a 4BPP monochrome one.

Uli

[1] http://www.linux-mips.org/archives/linux-mips/2005-01/msg00095.html
What happened to those, btw? They at least Work For Me(tm).

Cool. I will look it over and give a run. I need to make a few changes to 
properly support the fbdev api.
 


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click