Re: [PATCH] Logo code fixes part 2.
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2005-02-15 09:11:50
On Mon, 14 Feb 2005, James Simmons wrote:
quoted hunk ↗ jump to hunk
--- linus-2.6/drivers/video/logo/logo.c 2005-02-11 16:55:28.000000000 -0800 +++ fbdev-2.6/drivers/video/logo/logo.c 2005-02-14 10:19:21.000000000 -0800@@ -66,8 +66,10 @@ logo = &logo_linux_clut224; #endif #ifdef CONFIG_LOGO_DEC_CLUT224 - /* DEC Linux logo on MIPS/MIPS64 */ + /* DEC Linux logo on MIPS/MIPS64 or ALPHA */ +#ifndef CONFIG_ALPHA
^^^^^^^^^^^^^^^^^^^^ Wouldn't it be more logical to put a `#ifdef CONFIG_MIPS' here?
if (mips_machgroup == MACH_GROUP_DEC) +#endif logo = &logo_dec_clut224; #endif #ifdef CONFIG_LOGO_MAC_CLUT224
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click