video/pxafb: reorder add_wait_queue() and set_current_state()

Started by unknown sender on Jan 10, 2005

Subsystems (1)

Maintainers (1)

DORMANTno replies

open the first message on its own page

Message details and related content


Any comments would be, as always, appreciated.

-Nish

Description: Reorder set_current_state() and add_wait_queue(). There is
a chance that a signal could be missed in between the two functions
currently.

Signed-off-by: Nishanth Aravamudan <redacted>
Signed-off-by: Domen Puncer <redacted>
---


 kj-domen/drivers/video/pxafb.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/video/pxafb.c~reorder-state-drivers_video_pxafb drivers/video/pxafb.c
--- kj/drivers/video/pxafb.c~reorder-state-drivers_video_pxafb	2005-01-10 18:00:25.000000000 +0100
+++ kj-domen/drivers/video/pxafb.c	2005-01-10 18:00:25.000000000 +0100
@@ -740,8 +740,8 @@ static void pxafb_disable_controller(str
 
 	DPRINTK("Disabling LCD controller\n");
 
-	add_wait_queue(&fbi->ctrlr_wait, &wait);
 	set_current_state(TASK_UNINTERRUPTIBLE);
+	add_wait_queue(&fbi->ctrlr_wait, &wait);
 
 	LCSR = 0xffffffff;	/* Clear LCD Status Register */
 	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */
_


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help