Thread (5 messages) 5 messages, 3 authors, 2004-12-13

Re: Bug on atyfb

From: Antonino A. Daplas <hidden>
Date: 2004-12-10 21:19:33

On Saturday 11 December 2004 04:44, Lucas Correia Villa Real wrote:
Hi,

I'm trying to use atyfb on 2.6.10-rc3, but I'm getting a kernel oops just
at modprobe time. By tracking the problem, it seems that 'pll_limits.xclk'
is the heart of the problem, as seen in line 2210 from atyfb_base.c:

par->xclk_per = 1000000/par->pll_limits.xclk;

It happens that pll_limits.xclk is zero, because of an attribution made on
line 3246:

par->pll_limits.xclk = pll_block.XCLK_max_freq/100;

pll_block.XCLK_max_freq, in this case, is read from BIOS a few lines above
(at line 3229, to be more precise), and the value being returned from this
copy here is 20. So we have a problem, since the result from 20/100 = 0
will be used as denominator to set par->xclk_per's value.
Buggy BIOS?  Why not skip the init_from_bios() step, since xclk will be
initialized in the function correct_chipset(), just a few lines above?

If that works, perhaps a boot option can be added such as no_bios?

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help