Thread (4 messages) flat view 4 messages, 2 authors, 2004-11-27

Re: [2.6 patch] sstfb.c: make some code static

From: Alan Cox <hidden>
Date: 2004-11-27 00:02:03
Also in: lkml

On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote:
The patch below makes some needlessly global code static.
No it doesn't. It makes some functions static (which is fine) and adds
some nasty messy pointless #ifdefs. It touches no variable at all.

Please check your description texts and also don't fill the kernel with
ifdef crap. Probably the __setup stuff should be a module param new
style too.



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help