[PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

3 messages, 2 authors, 2004-11-18 · open the first message on its own page

[PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

From: Andrew Walrond <hidden>
Date: 2004-11-18 12:39:32

Fix typo introduced during changes to use NV_ macros,
which caused screen corruption when using rivafb

signed-off-by: Andrew Walrond <redacted>


diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
--- a/drivers/video/riva/riva_hw.c      2004-11-18 12:32:15 +00:00
+++ b/drivers/video/riva/riva_hw.c      2004-11-18 12:32:15 +00:00
@@ -1556,7 +1556,7 @@
         NV_WR32(chip->PGRAPH, 0x0000085C, state->pitch3);
         NV_WR32(chip->PGRAPH, 0x00000860, state->pitch3);
         NV_WR32(chip->PGRAPH, 0x00000864, state->pitch3);
-        NV_WR32(chip->PGRAPH, 0x000009A, NV_RD32(chip->PFB, 0x00000200));
+        NV_WR32(chip->PGRAPH, 0x000009A4, NV_RD32(chip->PFB, 0x00000200));
         NV_WR32(chip->PGRAPH, 0x000009A8, NV_RD32(chip->PFB, 0x00000204));
         }
             if(chip->twoHeads) {

Re: [Linux-fbdev-devel] [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

From: Andrew Walrond <hidden>
Date: 2004-11-18 12:56:03

Fixing this typo cures the screen corruption I was seeing on both 32 and 64bit 
x86_64 kernels.

Thanks for the help tracking this down. Please apply!

Andrew Walrond


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8

Re: [Linux-fbdev-devel] [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)

From: Antonino A. Daplas <hidden>
Date: 2004-11-18 23:10:15

On Thursday 18 November 2004 20:55, Andrew Walrond wrote:
Fixing this typo cures the screen corruption I was seeing on both 32 and
64bit x86_64 kernels.

Thanks for the help tracking this down. Please apply!
No, thank _you_ for the help tracking this down :-)

Tony




-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help