fbdev: Fix mode handling in rivafb if with no EDID

Started by Antonino A. Daplas on Nov 7, 2004

Subsystems (2)

Maintainers (2)

DORMANTno replies

open the first message on its own page

Message details and related content
The current code in rivafb will not accept modes other than 640x480-60 if
the the EDID block is absent.

This patch changes the behavior to the opposite, if without an EDID, rivafb
will accept all modelines coming from userspace (2.4 behavior).

Signed-off-by: Antonino Daplas <redacted>
---

 fbdev.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -Nru a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c
--- a/drivers/video/riva/fbdev.c	2004-11-06 06:21:26 +08:00
+++ b/drivers/video/riva/fbdev.c	2004-11-07 21:32:09 +08:00
@@ -1126,7 +1126,7 @@
 		}
 	}
 
-	if (!mode_valid && !list_empty(&info->modelist))
+	if (!mode_valid && info->monspecs.modedb_len)
 		return -EINVAL;
 
 	if (var->xres_virtual < var->xres)
@@ -2017,7 +2017,6 @@
 	}
 
 	fb_destroy_modedb(info->monspecs.modedb);
-	info->monspecs.modedb_len = 0;
 	info->monspecs.modedb = NULL;
 	if (register_framebuffer(info) < 0) {
 		printk(KERN_ERR PFX





-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help