Re: [Linux-fbdev-devel] Re: 2.6.9 bug: linux logo not displayed in vga16fb (bug found)

On Tuesday 26 October 2004 23:54, Ludovic Drolez wrote:

Ludovic Drolez wrote:

quoted

Hi !

I used to have a nice vga boot logo with my 2.6.7 kernel, but with the
2.6.9, my
boot logo has disappeared (same .config)...
It seems to switch to VGA, and some space is reserved for the logo, but
it is not displayed.
The logo appears with vesafb.

I made a few diffs between my old working 2.6.7 kernel and the 2.6.9 and
found something interesting in fbmem.c:

Should be fixed in the mm tree or the latest bk snapshot. Or you can try this
very patch.

Tony

diff -uprN linux-2.6.9-rc1-mm4-orig/drivers/video/vga16fb.c linux-2.6.9-rc1-mm4/drivers/video/vga16fb.c

--- linux-2.6.9-rc1-mm4-orig/drivers/video/vga16fb.c	2004-09-07 21:18:35.000000000 +0800
+++ linux-2.6.9-rc1-mm4/drivers/video/vga16fb.c	2004-09-07 21:30:39.059300648 +0800

@@ -1306,7 +1306,7 @@ void vga16fb_imageblit(struct fb_info *i
 {
 	if (image->depth == 1)
 		vga_imageblit_expand(info, image);
-	else if (image->depth <= info->var.bits_per_pixel)
+	else
 		vga_imageblit_color(info, image);
 }