Re: [PATCH 1/2] fbdev: S3 Savage Framebuffer Driver
flat view
From: Andrew Morton <hidden>
Date: 2004-10-25 09:04:59
"Antonino A. Daplas" [off-list ref] wrote:
S3 Savage Frambuffer Driver for the following chipsets:
build fixes: drivers/video/savage/savagefb.c:1368: macro `SavagePrintRegs' used without args drivers/video/savage/savagefb.c:1926: macro `SavagePrintRegs' used without args drivers/video/savage/savagefb.c:2141: macro `SavagePrintRegs' used without args drivers/video/savage/savagefb.c: In function `savagefb_init': drivers/video/savage/savagefb.c:2276: warning: implicit declaration of function `savagefb_setup' Signed-off-by: Andrew Morton <redacted> --- 25-akpm/drivers/video/savage/savagefb.c | 5 ++--- 25-akpm/drivers/video/savage/savagefb.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff -puN drivers/video/savage/savagefb.h~savagefb-build-fix drivers/video/savage/savagefb.h
--- 25/drivers/video/savage/savagefb.h~savagefb-build-fix 2004-10-25 01:59:47.303620792 -0700
+++ 25-akpm/drivers/video/savage/savagefb.h 2004-10-25 01:59:51.100043648 -0700@@ -21,7 +21,7 @@ # define DBG(x) printk (KERN_DEBUG "savagefb: %s\n", (x)); #else # define DBG(x) -# define SavagePrintRegs(x) +# define SavagePrintRegs(...) #endif
diff -puN drivers/video/savage/savagefb.c~savagefb-build-fix drivers/video/savage/savagefb.c
--- 25/drivers/video/savage/savagefb.c~savagefb-build-fix 2004-10-25 02:00:18.228919432 -0700
+++ 25-akpm/drivers/video/savage/savagefb.c 2004-10-25 02:01:45.080715952 -0700@@ -2248,9 +2248,9 @@ static void __exit savage_done (void) /* ************************* init in-kernel code ************************** */ -#ifndef MODULE int __init savagefb_setup(char *options) { +#ifndef MODULE char *this_opt; if (!options || !*options)
@@ -2259,10 +2259,9 @@ int __init savagefb_setup(char *options) while ((this_opt = strsep(&options, ",")) != NULL) { mode_option = this_opt; } - +#endif /* !MODULE */ return 0; } -#endif /* !MODULE */ int __init savagefb_init(void) {
_ ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl