Re: [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization

From
Antonino A. Daplas <hidden>
Date
2004-09-04 06:53:11
Also in
lkml
Reply to
Thomas Winischhofer, 2004-09-04
On Saturday 04 September 2004 11:36, Thomas Winischhofer wrote:
quoted
5. Because driver initialization will be dependent on the link order,
hardware that depends on other subsystems (agpgart, usb, serial, etc) may
choose to initialize after the subsystems they depend on.

Signed-off-by: Antonino Daplas <redacted>
I don't really see a benefit but it's ok with me.
Mainly cleanup, but also point #5.  The i810fb, for instance, depends on agpgart, but
agpgart gets initialized way after fbdev.  The workaround is for i810fb to explicitly
call intel_agp_init().  Besides the ugliness, forcibly initializing the agpgart subsystem
out of sequence may cause problems.

With this change, in theory, I can move i810fb's link order so it gets initialized after
agpgart.
(Thanks for considering the "unified" nature of sisfb, by the way. Very
considarate. Very much appreciated.)

I assume that you tested this stuff before posting it here.
Yes, with hardware that I have.  I did try to at least compile test what I can.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
Thread (9 messages) 9 messages, 4 authors, last reply 2004-09-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help