[PATCH] Fix possible leak in fbcon code. (fwd)
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2004-09-02 09:45:19
---------- Forwarded message ---------- Date: Wed, 1 Sep 2004 16:51:22 +0100 From: Dave Jones <redacted> To: linux-kernel@vger.kernel.org Subject: [PATCH] Fix possible leak in fbcon code. Spotted with the source checker from Coverity.com. Signed-off-by: Dave Jones <redacted> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/console/fbcon.c linux-2.6/drivers/video/console/fbcon.c
--- bk-linus/drivers/video/console/fbcon.c 2004-08-24 00:02:40.000000000 +0100
+++ linux-2.6/drivers/video/console/fbcon.c 2004-09-01 13:31:12.000000000 +0100@@ -983,6 +983,7 @@ static void fbcon_init(struct vc_data *v vc->vc_y += logo_lines; vc->vc_pos += logo_lines * vc->vc_size_row; kfree(save); + save = NULL; } if (logo_lines > vc->vc_bottom) { logo_shown = -1;
@@ -1004,6 +1005,8 @@ static void fbcon_init(struct vc_data *v softback_top = 0; } } + if (save) + kfree(save); } static void fbcon_deinit(struct vc_data *vc) -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click