Re: Fw: Re: 2.6.8.1-mm2

On Fri, 20 Aug 2004, Antonino A. Daplas wrote:

On Friday 20 August 2004 16:29, Andrew Morton wrote:

quoted

From: ismail dönmez <redacted>
On Thu, 19 Aug 2004 01:42:04 -0700, Andrew Morton [off-list ref] wrote:

quoted

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.8.1/2.6
.8.1-mm2/

Minor issue but still no penguin logo on framebuffer. Config attached in
case.

The latest fbdev changes in the mm tree differentiates between bpp and color depth.
The vesafb driver at 8 bpp has a color depth of 6 only (try fbset -i) allowing only for
64 colors.  So fbdev assumes that vesafb at this depth cannot draw a 224-color
logo.

Try using the 16-color logo instead.  The correct fix is for vesafb to correctly determine
the true capability of the hardware instead of arbitrarily setting the color depth at 6.

It's not arbitrarily: it's the old convention of setting the color bitfield
lengths to the number of significant bits of that color component. VGA has 2^18
colors.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285