Re: [Linux-fbdev-devel] Re: [PATCH 5/5] [I810FB]: i810fb fixes

On Saturday 31 July 2004 08:07, Adrian Bunk wrote:

If you select something, you have to ensure that the dependencies of
what you select are fulfilled.

Since AGP_INTEL depends on X86 && !X86_64 , you must add this to the
dependencies of FB_I810 if it selects AGP_INTEL.

Thanks.  Incremental patch included.

Tony

1. Make i810fb depend on X86 but not X86_64
2. Fixed typo in i810_init_monspecs(). Reported by Manuel Lauss [off-list ref].

Signed-off-by: Antonino Daplas <redacted>
---

diff -uprN linux-2.6.8-rc2-mm1-orig/drivers/video/i810/i810_main.c linux-2.6.8-rc2-mm1/drivers/video/i810/i810_main.c

--- linux-2.6.8-rc2-mm1-orig/drivers/video/i810/i810_main.c	2004-07-31 16:52:12.341681400 +0800
+++ linux-2.6.8-rc2-mm1/drivers/video/i810/i810_main.c	2004-07-31 16:53:18.937557288 +0800

@@ -1656,7 +1656,7 @@ static void __devinit i810_init_monspecs
 		info->monspecs.hfmax = hsync2;
 	if (!info->monspecs.hfmin)
 		info->monspecs.hfmin = hsync1;
-	if (hsync1 < hsync2) 
+	if (hsync2 < hsync1) 
 		info->monspecs.hfmin = hsync2;
 
 	if (!vsync1)

diff -uprN linux-2.6.8-rc2-mm1-orig/drivers/video/Kconfig linux-2.6.8-rc2-mm1/drivers/video/Kconfig

--- linux-2.6.8-rc2-mm1-orig/drivers/video/Kconfig	2004-07-31 16:52:12.337682008 +0800
+++ linux-2.6.8-rc2-mm1/drivers/video/Kconfig	2004-07-31 16:53:21.306197200 +0800

@@ -457,7 +457,7 @@ config FB_RIVA_DEBUG
 
 config FB_I810
 	tristate "Intel 810/815 support (EXPERIMENTAL)"
-	depends on FB && EXPERIMENTAL && PCI	
+	depends on FB && EXPERIMENTAL && PCI && X86	
 	select AGP
 	select AGP_INTEL
 	help