Re: Re: [PATCH 1/4][RESEND][FBDEV]: Core fbcon fixes
From: Antonino A. Daplas <hidden>
Date: 2004-06-24 01:11:14
Wow. That is a big patch. I will loook it over. I had some ideas I like
It is a big patch. Needed because fb_console_init and set_con2fbmap are just plain broken. Really, you need to adjust module reference counts, re/deinitialize the cursor timer, initialize/reinitialize the global arrays, preserve user fonts, consider that you can have multiple fbdevs mapped to different consoles, consider that you can load/unload fbdev modules at will, etc. All the above complexities were introduced because fbdev was separated from fbcon. Not doing/taking note of any of the above is just asking for trouble. (The 2.4 framework is simpler because fbcon is automatically initialized with fbdev). Plus, the patch also combined the changes needed to prevent screen corruption at boot time. Note that the logo code is actually simplified by the changes.
to try myslef. I like to have you be able to map the fbdevs to teh correct VCs at boot time. If one is modular as soon as you load that module it maps to fbcon automatically :-) Like in 2.4.X.
Setcon2fbmap is already fixed so you can use it to choose which framebuffers to load. Choosing which fbdev to map to a console at boot time is as simple as adding a boot parameter and use that in fb_console_init. As for the 2.4 behavior of automatically initializing fbcon when an fb module is loaded, that is also simple. Add another notifier event which is called during register_framebuffer that will subsequently call fb_console_init(). However you implement it, with this patch, the framework is already in place. Tony ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com