Re: [PATCH 3/3] [FBDEV]: Hardware State Notification

On Thursday 24 June 2004 00:02, Benjamin Herrenschmidt wrote:

You don't need that. A method for that was _ALREADY_ added to the kernel,
it's based on the fact that the blank() callback is called on switches
between KD_TEXT and KD_GRAPHICS. After discussing the issue with Linus,
we decided to add a parameter to it indicating the nature of the
switch. You should be able to rely on that. Actually, if you look at
the code, I'm forcing a set_par in this case. If this doesn't work, then
I may have missed a code path, and that should be fixed but there is no
need at this point to change the infrastructure.

Thanks Ben, I see it now. I did not realize it was in the console_blank hook.  (I did
not follow this list for a time). And no, I don't think you missed a code path.  The 
problem is that we are calling fb_set_var->set_par too early, before X has really
given up on the hardware. We can fix this by setting some kind of flag while in
fbcon_blank,  and depending on the setting of this flag, force a set_par in 
fbcon_switch instead.

I'll concoct a patch later. (I'll test James' new patch first).

Tony




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com