Re: Re: [PATCH] sisfb accel capabilities

On Thu, 3 Jun 2004, David Eger wrote:

I guess I shouldn't mark it "stupid shit" until I actually have the replacement
code ready ;-)  You want me to revise the name of the #define?

Yes, please do so. We need it for backwards compatibility.

Basically, I think the name FB_ACCELF_TEXT is silly and misleading:
+ it means the kernel is enabling the acceleration engine; not really to do with
_TEXT

Well, inside the kernel, the acceleration engine is used for acceleration the
text console emulation only.

+ it's not really a flag, since it and zero are the only valid settings

What other things do you do with a flag? Waiving? ;-)

+ it doesn't really belong with the mode settings (i.e. 1024x768, 60 Hz 32bpp)
which is what var is, mainly

A long time ago, we also intended to use it to switch to real text mode on
cards that supported it[*]. But no one ever implemented that.

[*] Remember, fbdev originated on platforms without VGA graphics. Although some
graphics cards were based on VGA-compatible chips, they all booted in graphics
mode.

But it is how things are done now.  So yes, fbset -accel 0 => var.accel_flags =

Indeed.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
This SF.Net email is sponsored by the new InstallShield X.
From Windows to Linux, servers to mobile, InstallShield X is the one
installation-authoring solution that does it all. Learn more and
evaluate today! http://www.installshield.com/Dev2Dev/0504