Thread (5 messages) 5 messages, 2 authors, 2004-05-19

Re: vga16fb broke

From: James Simmons <hidden>
Date: 2004-05-19 22:09:40
Also in: lkml

quoted
quoted
 	/* XXX share VGA_FB_PHYS and I/O region with vgacon and others */
 
-	vga16fb.screen_base = ioremap(VGA_MAP_MEM(VGA_FB_PHYS), VGA_FB_PHYS_LEN);
+	vga16fb.screen_base = VGA_MAP_MEM(VGA_FB_PHYS);
 	if (!vga16fb.screen_base) {
 		printk(KERN_ERR "vga16fb: unable to map device\n");
 		ret = -ENOMEM;
This will make the driver on all platforms. 
There's a missing word in that sentence.  Was it "work" or "crash"?  This
matters ;)
works :-)
quoted
quoted
and that ARM and others need to teach their VGA_MAP_MEM() to do an internal
ioremap().

Or do you mean something else?  Please be more clear?
I like to see the VGA_MAP_MEM hack go away and be replaced with ioremap.
If you can cut a patch we can ask arch maintainers to review and test it.
I could but that would take some time. For now apply your fix.
Actually Ihave a newer vga16 driver for you I can push you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help