Re: fbset noaccel

On Saturday 29 May 2004 20:14, David Eger wrote:

[ reads through fbset code ]

So it looks like fbset turns off acceleration by setting up the accel flag
in var (that FB_ACCELF_TEXT oddity).

While it makes sense that changing acceleration is a mode-switch item
(quiescing video engine and such), it seems more like it should be an ioctl
(or sysfs!) thing now...  Changing certain bits of var and hoping that
set_var() will guess in the correct way seems generally b0rken...

comments?

It's not as bad as it seems.  As long as an accelerated driver does not ignore 
this flag and properly flushes->syncs->disables the accel engine on a 
set_var, it should work.  Plus, a lot of apps clear/depend on this flag 
(XFree86-fbdev, fbset, DirectFB, etc).

I agree though that turning off/syncing/flushing the accel engine deserves 
it's own ioctl/method so as to completely separate it from mode switching 
which is a different process in itself.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click