[ PATCH-LINK ] fb accel capabilities - take 2

From
David Eger <hidden>
Date
2004-05-15 13:54:07
Reply to
Lucas Correia Villa Real, 2004-05-05
I've taken Geert's suggestion and put the framebuffer capabilities flags 
in fbinfo.flags as follows:

 /* FBIF = FB_Info.Flags */
 #define FBIF_MODULE		0x0001	/* Low-level driver is a module */
 #define FBIF_HWACCEL_DISABLED	0x0002

 /* hints */
 #define FBIF_PARTIAL_PAN_OK	0x0040 /* otw use pan only for double-buffering */
 #define FBIF_READS_FAST		0x0080 /* soft-copy faster than rendering */

 /* hardware supported ops */
 #define FBIF_HWACCEL_NONE	0x0000
 #define FBIF_HWACCEL_COPYAREA	0x0100
 #define FBIF_HWACCEL_FILLRECT	0x0200
 #define FBIF_HWACCEL_ROTATE	0x0400
 #define FBIF_HWACCEL_IMAGEBLIT	0x0800
 #define FBIF_HWACCEL_XPAN	0x1000
 #define FBIF_HWACCEL_YPAN	0x2000
 #define FBIF_HWACCEL_YWRAP	0x4000

The patch is very large (40 kilobytes), but 27 of those kilobytes are just 
the work of running 's/FBINFO_FLAG_DEFAULT/FBIF_DEFAULT/g'.  I've posted the
patch at http://www.yak.net/random/fbdev-patches/accel-cap-take2

The files there are:

rev-1.1415.radeonfb-copyarea-corruption-fix.patch
	This is in the mainline kernel, but not yet applied to benh's tree ;)

rev-1.1416.james-console-init-cleanup.patch
	James's patch, modified to apply against benh's tree.

rev-1.1417.fb-accel-capabilities.patch
	Baseline patch to make framebuffer/fbcon interaction more sane by 
	basing the fbcon heuristics on capabilities advertized by underlying 
	framebuffer via the fb_info.flags field.

	This patch updates fbcon, fb.h, and skeletonfb.c.
	It also does a 's/FBINFO_FLAG_DEFAULT/FBIF_DEFAULT/g' on the fb drivers 
	to let them compile.  
	It does *not* yet update the drivers themselves.  They should compile 
	and work, but their hinting is not correct yet, meaning most fb drivers
	will be slow until I set the flags to the right hinting driver-by-driver.

If the patch looks good to you (James, Geert, BenH), I'd like to forward
it on to Linus followed by the individual driver updates (that'll take
a little longer -- I need to revise how drivers do things like remember
noaccel, etc. and update them).

-dte


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
Thread (4 messages) 4 messages, 3 authors, last reply 2004-05-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help