,On Mon, 2004-04-19 at 11:46, David Eger wrote:

Dear Ben,

Please apply this patch to the radeonfb driver (I think of you as the
maintainer for this driver) and then forward to James and Linus :-)

This fixes the same problem as mentioned before -- overlapping
regions sent to copyarea() get fux0r3d.  This patch corrects my earlier
braindamage of setting up w, h, dx, etc. and then forgetting to use them
later on.  Ah, having two versions of the same code (userspace and kernel
space) -- little details like that just float past the eye...  no problem
with fbcon at all, as i previously speculated.  apologies to james.

BTW, James, did we decide what is the best way to set fbcon accel
mode ? For drivers with copyarea accelerated, we want YMOVE. I'd like
a patch to send Linus/Andrew asap along with some pending radeonfb
fixes for that.

Ben.




-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click