Re: Re: [PATCH] Remove voodoo code from i2c

--- Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

On Sat, 2004-03-06 at 13:10, Jon Smirl wrote:

quoted

Can this be written as a generic i2c probe function by calling i2c chanel
functions instead of directly calling radeon_gpio_setscl, etc? The i2c

chanel

quoted

functions will then in turn call radeon_gpio_setscl, etc.

Why ? we aren't doing normal i2c big banging here, just hacking
around.

If I understand correctly, this code is needed to enable DDC on older monitors. 
If this is the case it is a generic problem and it needs to be corrected in all
of the framebuffer drivers. Correcting it in all of the drivers is easier if the
code is written in the generic i2c form.

Also, how do we know this is working? Nobody can come up with one of the
monitors that needs this or even a spec describing it.

The discussion about this got started around a port of 2.4 ddcmon (i2c device
driver like eeprom) to 2.6 and sysfs. The code in the radeon driver is not in
ddcmon and the question is, should it be added? If it should be added it needs
to be converted to the i2c generic form, not the radeon specific one.


=====
Jon Smirl
jonsmirl@yahoo.com

__________________________________
Do you Yahoo!?
Yahoo! Search - Find what you’re looking for faster
http://search.yahoo.com


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click