Re: [PATCH] Fix get_std_timing
From: James Simmons <hidden>
Date: 2004-03-04 22:45:35
Ug. I applied the fix. I will be pushing the new monitor code as soon as ben sends me bugs he found as well. On Thu, 4 Mar 2004, Kronos wrote:
quoted hunk ↗ jump to hunk
Hi, I thought that this was fixed ages ago, but I see that the bug it's still here. To recap, get_std_timing will exit after the first iteration on VESA modedb. Fix is trivial, James please apply:--- linux-2.6/drivers/video/fbmon.c.orig Thu Mar 4 23:11:43 2004 +++ linux-2.6/drivers/video/fbmon.c Thu Mar 4 23:12:46 2004@@ -572,12 +572,12 @@ vesa_modes[i].yres == yres && vesa_modes[i].refresh == refresh) { *mode = vesa_modes[i]; - break; - } else { - calc_mode_timings(xres, yres, refresh, mode); - break; + return 1; } } + + calc_mode_timings(xres, yres, refresh, mode); + return 1; }Luca
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click