Re: 2.6.1 fb.h patch for userland application

Hello,

I had problems to use linux/fb.h from 2.6.1 to compile userland 
application microwindows. I made some changes to get microwindows 0.90 
to compile, please see patch below.

The include files atomic.h and spinlock.h are necessary for spinlock_t 
and atomic_t. workqueue.h doesn't compile for userspace application and 
doesn't seem to be necessary at all (?). u8 is undefined while compiling 
for userspace, use __u8 instead.

Is this patch OK?

Dirk

--- linux/include/linux/fb.h_orig     2003-12-30 19:58:12.000000000 +0100
+++ linux/include/linux/fb.h        2004-02-04 10:11:59.000000000 +0100

@@ -2,8 +2,9 @@
  #define _LINUX_FB_H

  #include <linux/tty.h>
-#include <linux/workqueue.h>
+#include <linux/spinlock.h>
  #include <asm/types.h>
+#include <asm/atomic.h>
  #include <asm/io.h>

  /* Definitions of frame buffers 
          */

@@ -339,8 +340,8 @@ struct fb_pixmap {
         __u32 scan_align;                 /* alignment per scanline 
     */
         __u32 flags;                      /* see FB_PIXMAP_* 
     */
                                           /* access methods 
     */
-       void (*outbuf)(u8 *dst, u8 *addr, unsigned int size);
-       u8   (*inbuf) (u8 *addr);
+       void (*outbuf)(__u8 *dst, __u8 *addr, __u32 size);
+       __u8 (*inbuf) (__u8 *addr);
         spinlock_t lock;                  /* spinlock 
     */
         atomic_t count;
  };