Re: Patch for review and testing

quoted

I like to submit this patch to linus today. Could you test it to see if it 
works on ppcs. 

Well... you didn't update the drivers calling get_EDID_from_OF (I think
only rivafb at this point). 

The patch is against the vanilla tree. In the fbdev-2.5 tree I have to 
update rivafb for this. Actually I will remove that code from rivafb. 

Also, I plan to deprecate that function in
fbmon anyway, so don't bother, leave it alone for now. The way the
display/EDID infos are laid out in the OF device tree isn't that
generic and I'm considering letting each driver has its own version...

Then I will remove it.

Also, that construct is plain wrong:

char *get_EDID_from_Firmware(struct device *dev)
{
        .../...
	pdev = to_pci_dev(dev);

Either pass a pci_dev in, or if not, at least check that you are
dealing with a pci device before casting struct device...

That was to make the function generic. Well it doesn't matter as I'm going 
to remove the OF function so the pci stuff can go away.

Finally, I don't see the point of submiting things to Linus at this
point, especially this patch which isn't critical (and you didn't even
submit driver changes for _using_ the new feature). 

Actually it is. The BIOS calls can hang some intel machines or make 
booting  up to 5 seconds longer waiting for the data. If this was not the 
case I wouldn't be submitting it.

Andrew is the
maintainer of current 2.6.x stable, patches have to go to him first,
stage in -mm for a while to be tested, and then go to Linus.

This is just making the code conditional.  I will send another patch in a 
minute then.




-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn